Add dual store support #3878
Merged
Add dual store support #3878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 2, 2025
Merged
ma2bd
approved these changes
May 5, 2025
linera-service/src/linera/command.rs
Outdated
| #[arg(long, default_value = "0")] | ||
| block_exporters: u32, | ||
|
|
||
| /// Use dual store (rocksdb and scylladb) instead of just scylladb. |
Contributor
There was a problem hiding this comment.
Can you mention kubernetes in the description?
Contributor
There was a problem hiding this comment.
We could also use separate command at some point, say, linera net start and linera net start-kubernetes.
Contributor
Author
There was a problem hiding this comment.
I do mention that this adds support for linera net up --kubernetes 🤔
Contributor
There was a problem hiding this comment.
I'm talking about the comment used for --help.
ndr-ds
force-pushed
the
05-02-add_dual_store_support
branch
from
f44e58c to
9b0eaf9
Compare
ndr-ds
force-pushed
the
05-02-adjust_state_hash_computation_bucket
branch
from
e83c215 to
3143c9d
Compare
ndr-ds
force-pushed
the
05-02-add_dual_store_support
branch
from
9b0eaf9 to
236c7e0
Compare
ndr-ds
force-pushed
the
05-02-adjust_state_hash_computation_bucket
branch
from
3143c9d to
a3d38ad
Compare
ndr-ds
force-pushed
the
05-02-add_dual_store_support
branch
2 times, most recently
from
9c06727 to
71609f6
Compare
ndr-ds
force-pushed
the
05-02-adjust_state_hash_computation_bucket
branch
from
a3d38ad to
63ff628
Compare
ndr-ds
force-pushed
the
05-02-add_dual_store_support
branch
2 times, most recently
from
7bff405 to
238f4fd
Compare
ndr-ds
changed the base branch from
05-02-adjust_state_hash_computation_bucket
to
graphite-base/3878
ndr-ds
force-pushed
the
05-02-add_dual_store_support
branch
from
238f4fd to
e6759df
Compare
ndr-ds
changed the base branch from
graphite-base/3878
to
05-06-recursively_create_parent_directories_when_creating_config_dir
ndr-ds
force-pushed
the
05-02-add_dual_store_support
branch
from
e6759df to
6472402
Compare
ndr-ds
force-pushed
the
05-06-recursively_create_parent_directories_when_creating_config_dir
branch
from
d858999 to
1cfe578
Compare
ndr-ds
force-pushed
the
05-02-add_dual_store_support
branch
from
6472402 to
5d1fcb5
Compare
ndr-ds
force-pushed
the
05-06-recursively_create_parent_directories_when_creating_config_dir
branch
from
1cfe578 to
2997a46
Compare
ndr-ds
force-pushed
the
05-02-add_dual_store_support
branch
2 times, most recently
from
5fcbbc5 to
dbc4647
Compare
ndr-ds
force-pushed
the
05-06-recursively_create_parent_directories_when_creating_config_dir
branch
from
2997a46 to
296337d
Compare
This was referenced May 9, 2025
Contributor
Author
ndr-ds
changed the base branch from
05-06-recursively_create_parent_directories_when_creating_config_dir
to
graphite-base/3878
ndr-ds
force-pushed
the
05-02-add_dual_store_support
branch
from
dbc4647 to
908312b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our benchmarks are currently using
DualStore, so it makes sense for us to add support to use it if we need it. We won't ideally need this, as the plan is to getScyllaDBto a state that we reach the big numbers with it.Proposal
This PR adds the
linera-protocolside support forDualStorenetworks, as well as support for doing locallinera net up --kubernetesruns withDualStoreTest Plan
Ran a local network with default params (scylladb) and
DualStore, both workRelease Plan